Skip to content

Fix the SQL adaper in Rhino 8#82

Merged
michaelhoehn merged 5 commits into
developfrom
SQL_Toolkit-#62-FixAdaperInRhino8
May 30, 2026
Merged

Fix the SQL adaper in Rhino 8#82
michaelhoehn merged 5 commits into
developfrom
SQL_Toolkit-#62-FixAdaperInRhino8

Conversation

@adecler

@adecler adecler commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

NOTE: Depends on

While it doesn't depend on those PR to compile, the solution provided here will only be fully working once those other two PRs are also merged/compiled:

Issues addressed by this PR

Closes #62

Now compile the SQL adapter for two different frameworks and copies the dlls in their respective sub-folders in BHoM\Assemblies

Test files

One file for each version of Rhino:
SQLCompatibilityTest.zip

Changelog

Additional comments

@adecler adecler requested a review from michaelhoehn May 19, 2026 15:43
@adecler adecler self-assigned this May 19, 2026
@adecler adecler added the type:bug Error or unexpected behaviour label May 19, 2026
This was referenced May 19, 2026
Merged
Merged
@adecler

adecler commented May 21, 2026

Copy link
Copy Markdown
Member Author

@BHoMBot check compliance

@bhombot-ci

bhombot-ci Bot commented May 21, 2026

Copy link
Copy Markdown

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 16 requests in the queue ahead of you.

@adecler

adecler commented May 21, 2026

Copy link
Copy Markdown
Member Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented May 21, 2026

Copy link
Copy Markdown

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 16 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented May 21, 2026

Copy link
Copy Markdown

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented May 21, 2026

Copy link
Copy Markdown

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented May 21, 2026

Copy link
Copy Markdown

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

michaelhoehn
michaelhoehn approved these changes May 26, 2026
View reviewed changes

@michaelhoehn michaelhoehn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested successfully in both Rhino 7 and Rhino 8. I can also confirm that each dll is referenced from the appropriate place: Rhino 7 => netfx and Rhino 8 => net7.0

@michaelhoehn

michaelhoehn commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@BHoMBot check installer -force

@bhombot-ci

bhombot-ci Bot commented May 26, 2026

Copy link
Copy Markdown

@michaelhoehn to confirm, the following actions are now queued:

  • check installer

@bhombot-ci

bhombot-ci Bot commented May 26, 2026

Copy link
Copy Markdown

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented May 26, 2026

Copy link
Copy Markdown

@michaelhoehn to confirm, the following actions are now queued:

  • check installer

@bhombot-ci

bhombot-ci Bot commented May 26, 2026

Copy link
Copy Markdown

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michaelhoehn

michaelhoehn commented May 26, 2026

Copy link
Copy Markdown
Contributor

@BHoMBot this is a DevOps instruction. Run a force check on: installer

@bhombot-ci

bhombot-ci Bot commented May 26, 2026

Copy link
Copy Markdown

@michaelhoehn I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci

bhombot-ci Bot commented May 26, 2026

Copy link
Copy Markdown

@michaelhoehn I have provided force checks to the checks requested.

@michaelhoehn

michaelhoehn commented May 27, 2026

Copy link
Copy Markdown
Contributor

@BHoMBot this is a DevOps instruction. Run a force check on: installer

@bhombot-ci

bhombot-ci Bot commented May 27, 2026

Copy link
Copy Markdown

@michaelhoehn I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci

bhombot-ci Bot commented May 27, 2026

Copy link
Copy Markdown

@michaelhoehn I have provided force checks to the checks requested.

@michaelhoehn michaelhoehn merged commit 0672f48 into develop May 30, 2026
12 checks passed
@michaelhoehn michaelhoehn deleted the SQL_Toolkit-#62-FixAdaperInRhino8 branch May 30, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelhoehn michaelhoehn michaelhoehn approved these changes

Assignees

@adecler adecler

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The SQL Adapter is not working in Rhino 8

2 participants

@adecler @michaelhoehn